Skip to content

Added a REST URI to retrieve the number of checked-in visitors... - #308

Open
oliverhummel wants to merge 4 commits into
devfrom
feature/REST/visitorCount
Open

Added a REST URI to retrieve the number of checked-in visitors...#308
oliverhummel wants to merge 4 commits into
devfrom
feature/REST/visitorCount

Conversation

@oliverhummel

@oliverhummel oliverhummel commented Jan 25, 2022

Copy link
Copy Markdown
Contributor

... in a room at a given moment.

Related Issue

Checklist

  • Is the code formatted correctly?
  • Unnecessary comments removed?
  • Printout statements removed?
  • If you made backend changes: Did all tests pass? Do you need to adjust some tests or write new ones?
  • Is your code easy to understand or do you need to insert some comments?
  • Explain the issue for the reviewer and your steps to solve the issue => makes it a lot more easy for the reviewer
  • Label your pull request (frontend/ backend/ testing/ styling/ sql/...)
  • Is the open source message included at the very beginning of every source code file?
  • Are all imports organized, i.e. are the imports up to date and have all package imports been removed?

@Gabril-E
Gabril-E marked this pull request as draft January 27, 2022 16:14
@Gabril-E

Copy link
Copy Markdown
Collaborator

converted to draft until data-privacy concerns are resolved

@Gabril-E

Copy link
Copy Markdown
Collaborator

as long as only ctt-testserver is active, privacy concerns are negligible because no real data must be stored.

@Gabril-E
Gabril-E marked this pull request as ready for review March 24, 2022 16:49
@oliverhummel

Copy link
Copy Markdown
Contributor Author

I would suggest that we add another environment variable to switch the API on or off and then deploy it on the testserver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants